Feature:SlangFilter 추가 닉네임에 욕설 유무 포함#208
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (48)
Walkthrough닉네임 슬랭 감지, 개인화 AI 인사이트(수집·캐시·생성), 몰입형/이미지 투표 확장, 채팅 처리를 포함한 기능 추가 및 관련 설정·테스트 보강이 이루어졌습니다. Changes주요 기능 및 인프라 변경
Estimated code review effort: 🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs:
Suggested labels: Suggested reviewers:
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
빌드 성공 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/com/ject/vs/user/port/WordService.java (1)
34-43:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win로딩 실패 시 슬랭 검사가 무력화(fail-open)됩니다.
init()에서slang.txt로딩이 실패하면slang은 빈 리스트로 남고, 이후containSlang은 항상false를 반환하여 모든 닉네임이 금칙어 검사를 통과합니다. 로그만 남기고 정상 기동되므로 운영 중 조용히 필터가 비활성화될 수 있습니다. 필수 리소스 로딩 실패 시 기동을 중단하거나 별도 헬스 지표로 노출하는 것을 검토해 주세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/ject/vs/user/port/WordService.java` around lines 34 - 43, The init() method currently swallows IOExceptions and leaves the slang list empty so containSlang will always return false; change init() (and callers if needed) to treat slang.txt as a required resource: when loadWords("classpath:data/slang.txt") throws, rethrow a runtime exception or call System.exit(1) (or set a failing health flag) so the application fails to start (or exposes an unhealthy status) instead of continuing with an empty slang list; ensure the change references init(), loadWords(...) and the slang field so the service either aborts startup or flips a health indicator when slang loading fails.
🧹 Nitpick comments (2)
src/main/java/com/ject/vs/user/adapter/web/UserController.java (1)
44-47: 💤 Low valueSwagger 문서화 누락:
@Operation추가 권장.인접한 다른 엔드포인트들은 모두
@Operation(summary=..., description=...)을 부여하고 있으나 신규/nickname/slang만 누락되어 API 문서에서 설명이 비게 됩니다. 일관성을 위해 추가해 주세요.📝 제안
+ `@Operation`(summary = "닉네임 금칙어 확인", description = "닉네임에 금칙어 포함 여부를 확인합니다.") `@PostMapping`("/nickname/slang") public ResponseEntity<NicknameCheckResponse> checkNicknameSlang(`@AuthenticationPrincipal` Long userId, `@RequestBody` UserNicknameRec nickname) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/ject/vs/user/adapter/web/UserController.java` around lines 44 - 47, Add Swagger metadata to the checkNicknameSlang endpoint by annotating the UserController.checkNicknameSlang method with `@Operation`(summary = "...", description = "...") similar to adjacent endpoints; include a concise summary like "Check nickname for slang" and a description stating the behavior (inputs: UserNicknameRec.nickname, requires authentication, returns NicknameCheckResponse), ensuring imports for io.swagger.v3.oas.annotations.Operation are present if missing.src/main/java/com/ject/vs/user/port/WordService.java (1)
84-86: 💤 Low value메서드명 문법 제안:
containSlang→containsSlang.3인칭 단수 형태가 자연스럽고
SlangFilter.containsSlang과도 일관됩니다. 호출부(UserService)도 함께 변경이 필요합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/ject/vs/user/port/WordService.java` around lines 84 - 86, Rename the method containSlang to containsSlang in WordService (change the method declaration name from containSlang to containsSlang) and update all call sites to use the new name (notably the UserService caller); keep the implementation body as-is (it already delegates to SlangFilter.containsSlang), and ensure any interfaces, overrides, and unit tests referencing containSlang are renamed to containsSlang so the code compiles and remains consistent with SlangFilter.containsSlang.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/ject/vs/util/SlangFilter.java`:
- Around line 40-48: containsSlang은 현재 입력 내부의 부분 문자열만 검사하므로 짧거나 일상어인
금칙어(slangList의 "시간","초딩","년" 등)에 대해 과도한 오탐이 발생합니다; 수정 방안으로 containsSlang과
kmpContains 호출 로직을 변경해 짧은 항목(예: 길이<=2 또는 <=3)이나 명시된 일상어 목록에 대해선 전체 단어 일치 또는 단어
경계 검사만 허용하고(예: 공백/문장부호/문자 경계 기준), 긴 항목에 대해서만 기존 부분 문자열 검색을 유지하도록 구현하세요; 이를 위해
containsSlang에서 각 slang에 대해 slang.length()를 검사하고 짧은/화이트리스트 항목은 단어 경계 검사
함수(isWordBoundaryMatch)로 처리하고 나머지는 kmpContains(text, slang.toCharArray())를 호출하도록
변경하세요.
- Line 44: SlangFilter currently iterates slangList without a null guard; add a
defensive null-check at the start of the public method in SlangFilter that uses
the slangList (e.g., if (slangList == null || slangList.isEmpty()) return
<no-op>), so the method treats a null list as empty and returns the input/result
unchanged (or false) instead of throwing NPE; update the method that contains
the for(String slang : slangList) loop to return early when slangList is null.
In `@src/main/resources/data/slang.txt`:
- Line 1: The first word contains a leading BOM (U+FEFF) so
WordService.loadWords currently yields "\uFEFF..." and String::trim doesn't
remove it; update loadWords to strip a leading BOM when reading lines (e.g.,
remove '\uFEFF' or use Character.isWhitespace check for U+FEFF) or ensure the
file is saved as BOM-free UTF-8; specifically modify WordService.loadWords to
call something like line = line.replaceFirst("^\uFEFF", "") (or equivalent)
before trimming and adding to the word list so the first forbidden word matches
correctly.
---
Outside diff comments:
In `@src/main/java/com/ject/vs/user/port/WordService.java`:
- Around line 34-43: The init() method currently swallows IOExceptions and
leaves the slang list empty so containSlang will always return false; change
init() (and callers if needed) to treat slang.txt as a required resource: when
loadWords("classpath:data/slang.txt") throws, rethrow a runtime exception or
call System.exit(1) (or set a failing health flag) so the application fails to
start (or exposes an unhealthy status) instead of continuing with an empty slang
list; ensure the change references init(), loadWords(...) and the slang field so
the service either aborts startup or flips a health indicator when slang loading
fails.
---
Nitpick comments:
In `@src/main/java/com/ject/vs/user/adapter/web/UserController.java`:
- Around line 44-47: Add Swagger metadata to the checkNicknameSlang endpoint by
annotating the UserController.checkNicknameSlang method with `@Operation`(summary
= "...", description = "...") similar to adjacent endpoints; include a concise
summary like "Check nickname for slang" and a description stating the behavior
(inputs: UserNicknameRec.nickname, requires authentication, returns
NicknameCheckResponse), ensuring imports for
io.swagger.v3.oas.annotations.Operation are present if missing.
In `@src/main/java/com/ject/vs/user/port/WordService.java`:
- Around line 84-86: Rename the method containSlang to containsSlang in
WordService (change the method declaration name from containSlang to
containsSlang) and update all call sites to use the new name (notably the
UserService caller); keep the implementation body as-is (it already delegates to
SlangFilter.containsSlang), and ensure any interfaces, overrides, and unit tests
referencing containSlang are renamed to containsSlang so the code compiles and
remains consistent with SlangFilter.containsSlang.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c2140d02-1c26-428d-83ab-50fc806bcb4a
📒 Files selected for processing (5)
src/main/java/com/ject/vs/user/adapter/web/UserController.javasrc/main/java/com/ject/vs/user/port/UserService.javasrc/main/java/com/ject/vs/user/port/WordService.javasrc/main/java/com/ject/vs/util/SlangFilter.javasrc/main/resources/data/slang.txt
Comment on lines
+40
to
+48
| public static boolean containsSlang(String input, List<String> slangList) { | ||
| if(input == null || input.isBlank()) return false; | ||
| char[] text = input.toCharArray(); | ||
|
|
||
| for(String slang : slangList) { | ||
| if(kmpContains(text, slang.toCharArray())) return true; | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
부분 문자열(substring) 매칭으로 인한 과도한 오탐 위험.
containsSlang은 닉네임에 금칙어가 부분 문자열로 포함되기만 하면 매칭됩니다. 그런데 slang.txt에는 시간(Line 2134), 초딩(Line 2106), 보딩(Line 2109), 년(Line 1473), 놈(Line 1474) 등 단독으로는 일상어이거나 매우 짧은 항목이 다수 포함되어 있습니다. 그 결과 시간여행자, 초딩탈출 같은 정상 닉네임이 차단되는 오탐이 광범위하게 발생합니다.
단어 경계 검사나 짧은/일상어 항목에 대한 별도 정책(완전 일치 등)을 도입하는 것을 검토해 주세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/java/com/ject/vs/util/SlangFilter.java` around lines 40 - 48,
containsSlang은 현재 입력 내부의 부분 문자열만 검사하므로 짧거나 일상어인 금칙어(slangList의 "시간","초딩","년" 등)에
대해 과도한 오탐이 발생합니다; 수정 방안으로 containsSlang과 kmpContains 호출 로직을 변경해 짧은 항목(예: 길이<=2
또는 <=3)이나 명시된 일상어 목록에 대해선 전체 단어 일치 또는 단어 경계 검사만 허용하고(예: 공백/문장부호/문자 경계 기준), 긴 항목에
대해서만 기존 부분 문자열 검색을 유지하도록 구현하세요; 이를 위해 containsSlang에서 각 slang에 대해
slang.length()를 검사하고 짧은/화이트리스트 항목은 단어 경계 검사 함수(isWordBoundaryMatch)로 처리하고 나머지는
kmpContains(text, slang.toCharArray())를 호출하도록 변경하세요.
| if(input == null || input.isBlank()) return false; | ||
| char[] text = input.toCharArray(); | ||
|
|
||
| for(String slang : slangList) { |
There was a problem hiding this comment.
slangList가 null일 때 NPE 가능성.
현재 호출부(WordService)는 빈 리스트로 초기화하므로 안전하지만, 공개 정적 메서드인 만큼 방어적으로 null 가드를 추가해두면 향후 오용을 예방할 수 있습니다.
🛡️ 제안
- if(input == null || input.isBlank()) return false;
+ if(input == null || input.isBlank() || slangList == null) return false;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/java/com/ject/vs/util/SlangFilter.java` at line 44, SlangFilter
currently iterates slangList without a null guard; add a defensive null-check at
the start of the public method in SlangFilter that uses the slangList (e.g., if
(slangList == null || slangList.isEmpty()) return <no-op>), so the method treats
a null list as empty and returns the input/result unchanged (or false) instead
of throwing NPE; update the method that contains the for(String slang :
slangList) loop to return early when slangList is null.
| @@ -0,0 +1,2141 @@ | |||
| 가슴빨아 | |||
There was a problem hiding this comment.
첫 줄에 BOM(U+FEFF)이 포함되어 첫 금칙어가 무력화됩니다.
파일 선두에 BOM이 있어 첫 항목이 "\uFEFF가슴빨아"로 로드됩니다. WordService.loadWords의 String::trim은 U+0020 이하 문자만 제거하므로 BOM은 제거되지 않고, 결과적으로 첫 번째 금칙어가 정상적으로 매칭되지 않습니다. 파일을 BOM 없는 UTF-8로 저장하거나, 로딩 시 선두 BOM을 제거하도록 처리해 주세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/resources/data/slang.txt` at line 1, The first word contains a
leading BOM (U+FEFF) so WordService.loadWords currently yields "\uFEFF..." and
String::trim doesn't remove it; update loadWords to strip a leading BOM when
reading lines (e.g., remove '\uFEFF' or use Character.isWhitespace check for
U+FEFF) or ensure the file is saved as BOM-free UTF-8; specifically modify
WordService.loadWords to call something like line = line.replaceFirst("^\uFEFF",
"") (or equivalent) before trimming and adding to the word list so the first
forbidden word matches correctly.
- VoteCommandService에서 ImageService 의존성을 Optional<ImageService>로 변경 - S3가 비활성화된 테스트 환경에서도 애플리케이션 컨텍스트가 정상 로드되도록 수정 - createWithImages 메서드에서 ImageService 없을 시 명확한 예외 메시지 제공
- findRandomExcluding: excludeIds 제외하고 랜덤 조회 - findRandom: 첫 조회용 랜덤 쿼리 - countOngoing: 진행 중 투표 개수 조회
- getNextRandom 메서드 시그니처 정의 - ImmersiveNextResult record 추가
- excludeIds 제외하고 랜덤 투표 조회 - 기존 toFeedItem 메서드 재사용 - imageUrl null 시 thumbnailUrl로 폴백 처리
- ImmersiveNextRequest: excludeIds, size 파라미터 - ImmersiveNextResponse: 기존 피드 응답 구조와 동일 - 무한 순환: 모든 투표 소진 시 빈 배열 반환
- imageUrl 있으면 그대로 반환 - imageUrl null이면 thumbnailUrl로 폴백
Order GET /api/chats results by lastMessageAt (newest first). Chats without messages are placed last.
Resolve chat message senderVoteOption from current participation only. Users who canceled their vote no longer expose A/B on past messages.
Member
Author
|
빌드 시작 |
|
빌드 성공 |
|
빌드 성공 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🔍 작업 내용
입력된 단어에 욕설데이터를 불러와 일치하는지 확인하는 유틸 클래스 생성
UserService 욕설 체크 메서드 추가
UserController 욕설 체크 엔드포인트 추가
📝 변경 사항
💬 리뷰어에게
Summary by CodeRabbit
새로운 기능
개선